Bump backstage to 1.31.1 #125
Conversation
🦋 Changeset detectedLatest commit: 10f49e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ivangonzalezacuna
force-pushed
the
bump-backstage
branch
from
826acba
to
680ffa9
Compare
ivangonzalezacuna
requested review from
heyLu
and removed request for
heyLu
|
I think this project is still using Yarn 1 (as seen in pipeline logs like https://github.com/spreadshirt/backstage-plugin-s3/actions/runs/11009109121/job/30568059033?pr=125), thus the linting issues. I'm having a look at doing it locally according to https://yarnpkg.com/getting-started/install, will report back how that goes. |
|
Giving up for today, I tried a bunch of things, but always ended up getting the same error. If you like we can have a look together tomorrow. |
Yes, I ended up giving up as well. It was pretty confusing. Also, in the thread I linked above, the guy just said bumping to yarn4 fixed it for him. I'm quite confused about what can be wrong for us. But yes, we can give it a check together. Maybe also checking his repos and using them as reference, in case something is missing for us |
ivangonzalezacuna
force-pushed
the
bump-backstage
branch
from
680ffa9
to
1a49e46
Compare
ivangonzalezacuna
force-pushed
the
bump-backstage
branch
from
1a49e46
to
165b66c
Compare
Along with the update, we also needed to bump "eslint" to the latest version, otherwise the "yarn lint" command would fail due to missing modules. Also needed to add "typescript" as dependency to make sure the "yarn tsc" command would work. Might have been removed from other dependencies we had in the past. Also ignore internal .yarn files for the prettier command
ivangonzalezacuna
force-pushed
the
bump-backstage
branch
from
165b66c
to
1b4b218
Compare
This has been done with the 'yarn up -R' command
Also took the chance and tried to bump the yarn version to 4.4.1, like suggested in the upgrade-helper and done in our instance as well.
However, this didn't shrink our yarn.lock file, but made it even bigger 😕 Also, there were some issues with commands like
yarn tscand so on, which I didn't really understood. I think I might have done it incorrectly, but I'm not sure.The linting issues we are having in the pipelines can be reproducible by others: https://discord.com/channels/687207715902193673/1285669437223206983